-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use string as default for unknown column type #260
Conversation
@krlmlr I'm curious to hear what you think about this proposed solution whenever you have a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
@krlmlr This would be a really helpful feature to have integrated into the package for a project I'm currently working on. Is there any chance of getting it merged into the next release candidate? |
@LeeMendelowitz: warnings don't seem to be raised for MariaDB. What do you see when you run the following: DBI::dbGetInfo(RMariaDB::mariadbDefault())$db.version
#> [1] "10.10.2-MariaDB" Created on 2023-03-16 with reprex v2.0.2 ? I'd like to stabilize the tests before merging. |
I added MySQL 8.0 configurations to main and merged it here, let's see what the tests say. @LeeMendelowitz: can you please help by reporting what the following code shows on your system: DBI::dbGetInfo(RMariaDB::mariadbDefault())$db.version
#> [1] "10.10.2-MariaDB" |
@krlmlr Sorry for the delay. I get "5.5.5-10.11.2-MariaDB-1:10.11.2+maria~ubu2204". For some reason
It didn't seem to be using the |
Thanks! |
PR for Issue #259.
Querying a JSON column on MySQL 8.0.26 returns a column of type 245, which is not handled by RMariaDB. This PR converts column of unknown type to string and issues a warning, which is similar to the RMySQL behavior.